search

jamtools / section-view

Section view component for the Jam Tools Composition App
1 stars 0 forks source link

Mobile-first UI implementation with Semantic UI #20

Open aelishRollo opened 4 weeks ago

aelishRollo commented 4 weeks ago

Check it out. It is not yet data driven, but it's a simple layout that I think adheres fairly well to the layout you drew. It's mobile-first but looks decent on desktop as well. Would love to hear your thoughts.

https://deploy-preview-20--section-view.netlify.app

Fixes https://github.com/jamtools/section-view/issues/18

Screenshots Light mode image image Dark mode image image
netlify[bot] commented 4 weeks ago

Deploy Preview for section-view ready!

Name Link
Latest commit d2bdbf3e9cc9b261aca4361e82db355a99162950
Latest deploy log https://app.netlify.com/sites/section-view/deploys/66805a6437b4310009e52d99
Deploy Preview https://deploy-preview-20--section-view.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mickmister commented 4 weeks ago

The project was failing to build based on an unused import. I fixed CI in commit https://github.com/jamtools/section-view/pull/20/commits/559a12f75fe287bbf844ca589e6a1df9b2b71fe7 to make it so linting is skipped during build (because building has no business worrying about that). I also fixed the linting job to check linting correctly.

Here is the one linting issue that needs to be addressed:

[eslint] 
src/Foo.tsx
  Line 2:74:  'Input' is defined but never used  @typescript-eslint/no-unused-vars
mickmister commented 4 weeks ago

Also for PRs focused on UI work, it's always good to include screenshots in the PR description. Ideally before & after pictures, but just the "after" pictures is fine too