search

jamtur01 / puppet-rundeck

Puppet integration with RunDeck
Apache License 2.0
45 stars 16 forks source link

hostname was getting set to the puppet master's fqdn in my case... #3

Closed mrisher closed 12 years ago

mrisher commented 12 years ago

I did find what seemed to be a bug… The resource file your program generated for me had the "hostname" parameter set to the puppet master, rather than the node, i.e. I had node like

<node name="events1003.impermium.com" 
    type="Node"
    description="events1003.impermium.com"
    …
    hostname="puppet.impermium.com"
/>

It was the same for all my nodes.

When I changed the following line from facts.values["fqdn"] to just n.name, it resolved the problem for me, but I assume this bug was due to a misconfiguration on my end rather than yours...

jamtur01 commented 12 years ago

This is quite odd because it should be pulling the fact values for the node NOT the master. Are any of of the other fact values wrong, i.e. belong to the master not the node?

lrhazi commented 12 years ago

I have this same issue. I get the XML with all the nodes. The nodes have the same attributes, except for "name" which is correct, everything else is the same. For example osName is RedHat, though I have many Solaris.

jamtur01 commented 12 years ago

Hmmm looks like the fact merge is broken. I'll take a look tonight hopefully.

jamtur01 commented 12 years ago

Fixed in 0.0.6.