search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

Install the .desktop file and icon for Jamulus Server (optionally or not) #1316

Closed yurivict closed 3 years ago

yurivict commented 3 years ago

In the FreeBSD port I added such desktop item. The desktop file is the same except Name=Jamulus Server, Comment=Jam Session Server, Exec=jamulus -s, Icon=jamulus-server.

The icon file src/res/fronticonserver.png is installed as jamulus-server.png.

This is a convenience feature to simplify starting the server.

You can make it optional with a qmake CONFIG option, or permanent.

jujudusud commented 3 years ago

Hi Yuri, hi all, I want to add a Jamulus server icon in Archlinux package too. I noticed that Windows 10 installs two differents icons while my package for Arch only installs one (the blue). I think this could be a good improvement if Il can simply have this icon in the .desktop.

ann0see commented 3 years ago

Yes. That would be good. I think you could create a Pull Request. But no guarantee that it'll get merged although I'd support it.

jujudusud commented 3 years ago

Is there anything new here? @yurivict do you pull request the new desktop file ?

yurivict commented 3 years ago

Sorry, I don't have spare cycles for this.

jujudusud commented 3 years ago

I will do that if it's ok for you. Just the time for to understand how to ... and it will be ok. :-) or just using 'sed' : sed -e 's%^Name=Jamulus%Name=Jamulus (server)%' -e 's%^Exec=Jamulus$%Exec=Jamulus -s%' \ "${pkgdir}/usr/share/applications/jamulus.desktop" > "${pkgdir}/usr/share/applications/jamulus-server.desktop" like in the PKGBUILD of archlinux adding fronticon and fronticon server instead.

ann0see commented 3 years ago

@jujudusud I can assign you to this issue if you want

jujudusud commented 3 years ago

@ann0see Ok !

ann0see commented 3 years ago

Ok great. I'll unsubscribe from this issue now.

jujudusud commented 3 years ago

The PR is here #1422

jujudusud commented 3 years ago

Need help here to make the new jamulus-server.desktop.in work with the autobuild. Anyone ?