jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

Disabled Loudspeaker Symbol not shown when Mono channel configuration (duplicate of #1074) #1324

Closed pappou99 closed 3 years ago

pappou99 commented 3 years ago

Description When channel configuration is set to mono, no signalisation is show, if others muted me. (cancelled loudspeakersymbol is missing)

To Reproduce Settings -> Audio Channels -> Mono Connect to server with other participiants. Please them to mute your channel. Now it should show you, that the other isn't hearing you, but no signalisation is shown. Settings -> Audio Channels -> Mono in / Stereo out Signalisation that others muted you is shown (disabled loudspeaker symbol)

Expected behavior Signalisation that others muted you is shown in any channel configuration (disabled loudspeaker symbol)

Operating system Win10Pro, Ubuntu

Version of Jamulus 3.7.0 also in 3.6.2 Additional context if configured to mono, the pan knob disappears and the fader grows. Perhaps the loudspeakersymbol is part of the pan module in gui?

gilgongo commented 3 years ago

Sorry, if this is a dupe of https://github.com/jamulussoftware/jamulus/pull/1074 do you mind if I close it?

pappou99 commented 3 years ago

Sorry, if this is a dupe of #1074 do you mind if I close it?

No, please do so.

ann0see commented 3 years ago

Closed since there's an open Pull request

gilgongo commented 3 years ago

OK, but manually closing is just more work as it would have been closed automatically when the PR was merged. But it's not a big deal.

ann0see commented 3 years ago

Yes. You're right. But let's leave it like that.

gilgongo commented 3 years ago

Oh actually it was a duplicate anyway - hehe. Never mind!