search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
988 stars 221 forks source link

windows/sound.cpp: Rename CheckDeviceCapabilities() #1409

Open hoffie opened 3 years ago

hoffie commented 3 years ago

Describe the bug CheckDeviceCapabilities() in windows/sound.cpp does more than what the name suggests: It has side effects such as updating instance variables such as lNumInChan.

Expected behavior

Have a name which makes it clear that updates happen.

Version of Jamulus d5d4691221b76bc648d605dac867aeaa561d0a52

cc @ann0see @pljones

DominikSchaller commented 3 years ago

Maybe a stupid question, but what does "good first issue" mean? Does it mean, it's a good issue for a new developer?

hoffie commented 3 years ago

what does "good first issue" mean? Does it mean, it's a good issue for a new developer?

Yes, this was the intention. I think this issue requires little Jamulus-specific context but could be worked on by some developer who is new to the project.

ann0see commented 2 years ago

Any news here? @DominikSchaller @henkdegroot or @pgScorpio (sorry for the pings...) do you want to rename the function?

pgScorpio commented 2 years ago

@ann0see

Any news here? @DominikSchaller @henkdegroot or @pgScorpio (sorry for the pings...) do you want to rename the function?

No, just wait for the sound redesign.... It's already changed there.