search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

Replace non-ASCII characters in recording file names #1424

Closed gilgongo closed 3 years ago

gilgongo commented 3 years ago

As discussed in https://github.com/jamulussoftware/jamulus/discussions/1384

Jamlus supports unicode characters in profile names (as it should), and the OS will also support them in file names too. However, Audacity (and possibly other apps) don't support unicode characters in file names. So if a profile name contains such a character, the server operator cannot import the recording file(s) due to the unicode character being present.

A suggested fix for this is to replace any non-ASCII characters with for example a hyphen when Jamulus writes the recording file using the client's profile name (so the LOF file will use the corrected filenames).

reinhardwh commented 3 years ago

Hello Jonathan, gilgongo,

excellent, thanks a lot.

One remark: Also the LOF file should use the corrected filenames.

ghost commented 3 years ago

Why can't the server operator simply rename the file?

softins commented 3 years ago

Why can't the server operator simply rename the file?

Because the filenames are also referenced within the Reaper and Audacity project files.

PR to follow.

reinhardwh commented 3 years ago

Excellent Well done Filenames and LOF created without special characters Thanks a lot