Mobile: Bad layout of settings dialog

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.

https://jamulus.io

Other

986 stars 221 forks source link

Mobile: Bad layout of settings dialog #1529

Open j-santander opened 3 years ago

j-santander commented 3 years ago

Describe the bug

With the code from master, the settings dialog in android is not layout correctly, with the rows appearing compressed as the screen is not tall enough.

To Reproduce

Install the latest application in android.

Expected behavior

Dialog should be layed out properly.

Screenshots

Screenshot_20210417-191524

Operating system

Android 11 - Google Pixel 3a

Version of Jamulus

Built from source at 3df60d6f9faf9bd9fc421187f4e62650abf0b1e0

Additional context

ngocdh commented 3 years ago

I confirm the issue. And it’s actually worse for iOS. In iOS, the issue exists for ClientDlg as well, where Android does much better. This might have to do with how Qt deals with different OSes.

ghost commented 3 years ago

You can get 20% more room! (3 FAT lines worth) without resorting to scroll-bars.

put Device beside the selector (as Audio Channels and Audio Quality is)
do the same with Buffer Delay (Buffer is good enough Delay is too much)
get rid of Measurements (heading)

ngocdh commented 3 years ago

I confirm the issue. And it’s actually worse for iOS. In iOS, the issue exists for ClientDlg as well, where Android does much better. This might have to do with how Qt deals with different OSes.

This is how it looks actually in iOS.

47A89825-4655-4124-B4C9-8C5D5C926B44 C009C8F1-32C2-4415-90DE-11C9872C62FB

ngocdh commented 3 years ago

Could anyone point me in the right direction to fix the UI for iOS? I couldn't figure it out, since the same code is working quite well for other platforms, even Android. Somehow the ClientDlg now looks even worse: I can now see only 2 sliders (the lower part only) in the mixer.

6BF420CE-EF95-4940-BA17-C650C9E9FB21

ann0see commented 3 years ago

You could open the UI in Qt Designer?

ngocdh commented 3 years ago

You could open the UI in Qt Designer?

Yes.

ann0see commented 3 years ago

Ok. Probably you need to play CX around with the spacers/items there to get a working UI

ngocdh commented 3 years ago

I tried. But couldn't make it work due to my very limited experience. There are two problems:

For iOS: it seems the UI is rendered in low resolution, in contrary to Android, where everything is rendered perfectly
For touch screens in general: The mixer should support touch screen so that user can navigate easily, small scrollbars around the mixer is not the best solution here. Qt must surely support touch screen right?

ann0see commented 3 years ago

Qt must surely support touch screen right?

Yes but this requires QML and probably a large rewrite of the whole UI.

Found https://wiki.qt.io/How_to_Port_From_Desktop_to_Mobile

pljones commented 1 year ago

I think we probably do need a complete UI rewrite in the near future for mobile support. Screenshot_20230812-121222 Decisions about how to lay out the screen haven't been based on which controls are necessary for use and which are merely informational.

ann0see commented 1 year ago

Agree. There were concepts for a new UI somewhere.