Alignment issues in r3.8.0beta

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.

https://jamulus.io

Other

997 stars 222 forks source link

Alignment issues in r3.8.0beta #1606

Closed henkdegroot closed 3 years ago

henkdegroot commented 3 years ago

Describe the bug The measurements section in the "audio/network settings" tab are not aligned nicely. Depending on the language used, the visual appearance is very different.

To Reproduce Open the "audio/network settings" tab in r3.8.0beta

Expected behavior Values should be aligned. Perhaps move the LED to the middle and have the value aligned to the right? (Just a suggestion)

Screenshots Screenshots in different languages: measurement_DE measurement_EN measurement_ES measurement_NL measurement_PT

Operating system Windows 10 Version 20H2

Version of Jamulus r3.8.0beta

hoffie commented 3 years ago

Thanks for the report. @dcorson-ticino-com @pljones You had recent changes in that area, can one of you check if/how this could be improved before the final release?

pljones commented 3 years ago

Ah - I'd meant to look into this more at the time. (I'd also like the numeric values right-aligned, rather than left aligned, if they're being changed.) It probably needs a grid layout inside the groupbox.

pljones commented 3 years ago

Better alignment - I'll raise a PR.

hoffie commented 3 years ago

The latest screenshot looks like it might still profit from some more spacing (e.g. before 906 kbps)?

pljones commented 3 years ago

Yeah... I couldn't see how to do that... Any ideas? (Both sides of the measurement values could do with about "2" space, I think.)

pljones commented 3 years ago

OK, found it.

softins commented 3 years ago

It would be even nicer if the numbers were right-aligned, rather than the units. I think to do that properly would require three columns, with the numbers right aligned in column 2 and the units left aligned in column 3.

pljones commented 3 years ago

That means code changes rather than just ui layout changes... At the moment the values are set to "---" when not connected. That doesn't have a unit. When you connect, the value is set to the number, space, the unit. To split it would mean two columns rather than one, the first having the "---" in and the second being empty when not connected and the number in the first and the unit in the second when connected. A bit more code.

pljones commented 3 years ago

Not connected:

Connected:

I've "cheated" slightly by allowing the "kbps" to colspan across both the columns below.

hoffie commented 3 years ago

This should be fixed by @pljones's development and merge of #1617, so I'm closing this issue. Let me know if I've missed something.