search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

Server: Delay panning status is not saved #1743

Closed hoffie closed 3 years ago

hoffie commented 3 years ago

It seems, that in server mode the 'delay pan' option is not stored in the 'ini'. I observed this on Windows 7 and on an Ubuntu based system.

Originally posted by @DetlefHennings in https://github.com/jamulussoftware/jamulus/discussions/1707#discussioncomment-771881

henkdegroot commented 3 years ago

Seems to correct :)

Please assign to me....so I can resolve it.

hoffie commented 3 years ago

Please assign to me

Done.

I'm a bit unsure if the fix should be included in 3.8.0. I think we should not merge if rc1 is the last rc (we could just document it as Known Issue and release 3.8.1 shortly afterwards). If we need an rc2 anyway (for the Mac issue), then we might as well merge a fix for this if it is ready in time.

I'm tagging it for 3.8.0 so it doesn't get lost, but we may move it to 3.8.1.

@jamulussoftware/maindevelopers What do you think?

ann0see commented 3 years ago

No. I‘d include it in 3.8.0

pljones commented 3 years ago

I'd go with 3.8.0 on the grounds of the Mac leak, otherwise I'd have said it wasn't important enough a fix.