Link ASIO setup page on error message if no ASIO driver was found

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.

https://jamulus.io

Other

988 stars 221 forks source link

Link ASIO setup page on error message if no ASIO driver was found #1756

Open ann0see opened 3 years ago

ann0see commented 3 years ago

Has this feature been discussed and generally agreed? No. But it's a simple fix. Describe the solution you'd like If you start Jamulus without an ASIO driver, the following message greets new users:

NoASIO

Although I made the text less verbose, it's still a lot to read. From my point of view, greeting a new user with an error message is bad UX. We should link the website for more information or think about something more friendly.

Proposed solutions

Add a button which links to the website (needs improved exception handling probably)
Add a clickable link in the error message (easy but not visible)
Do some fancy stuff: run an onboarding wizard?
Leave it as is since the installer already generates a warning

henkdegroot commented 3 years ago

I noticed when doing a build "with jack" there is also a message about missing ASIO, but at least that allows you to continue and show a different dialog after that with a hyper-link to where you should. (writing this from memory...not 100% sure about the dialog sequence). But perhaps that is something to consider for this dialog as well?

ann0see commented 3 years ago

That’s probably the installer?

BTW: the ability to skip the ASIO warning in the installer just turned out to be useful ;-).

henkdegroot commented 3 years ago

That’s probably the installer?

You are correct....obvious I did not read the issue well enough....and it even says "If you start Jamulus".....guessing we could look at adding the very same button as we show in the installer dialog?

ann0see commented 3 years ago

Yes. It's a bit different since it's C++ not NSIS code.

henkdegroot commented 2 years ago

@gilgongo, so should we extend the "error" dialog and add a link to: https://jamulus.io/wiki/Installation-for-Windows ?

gilgongo commented 2 years ago

I think so. We can probably anchor it to the ASIO section I think https://jamulus.io/wiki/Installation-for-Windows#asio

henkdegroot commented 2 years ago

Thought about that as well....a similar dialog is presented when using the JACK version. Should we update that dialog as well with a similar reference? We could use the anchor jack for this...and if that section will become available, you won't need to update the software and if the anchor is not there it just opens the web page.

Can the change for the JACK dialog be covered in the same PR? Do we need to create another issue for JACK? Or can we update this one to include the reference to JACK?

gilgongo commented 2 years ago

Ah yes, that would be good to cover JACK as well (so the link to https://jamulus.io/wiki/Installation-for-Linux#set-up-your-hardware perhaps?)

May as well include it in the same PR I think.

henkdegroot commented 2 years ago

I never checked, but does the dialog get generated for Linux/macOS as well? As if it is, then it might complicate the reference.

gilgongo commented 2 years ago

Is it the same as this dialogue? https://github.com/jamulussoftware/jamulus/issues/2041

Not sure what happens with macOS but there is a dialogue for a general sound driver error I think. We don't have anywhere to link to for that though since macOS Jamulus doesn't involve an intermediary system like JACK or ASIO.

henkdegroot commented 2 years ago

Is it the same as this dialogue? #2041

Yes correct, that is the same dialog except it is for JACK instead of ASIO.