Initial "no JACK" message has no translation

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.

https://jamulus.io

Other

1k stars 224 forks source link

Initial "no JACK" message has no translation #2041

Open SeeLook opened 3 years ago

SeeLook commented 3 years ago

Describe the bug When Jamulus is started without JACK the message appears:

and it is not translated

To Reproduce Just launch Jamulus but without JACK and with localisation other than English

Operating system Arch Linux

Jamulus Version 3.8.1beta1dev-4b5c6aaa-dirty

Additional context Seems to me like this message is invoked before QTranslator loads its stuff.

henkdegroot commented 3 years ago

I tested on windows and indeed it seems this message (and other messages related to sound initialisation) are generated before the selected language in Jamulus is loaded.

Another example is for instance, when the previous used/selected audio device is not available when Jamulus is started. In this case also the english text is displayed.

The issue header text is slightly miss leading in this case, as the translation does exists.

ignotus666 commented 3 years ago

Do you know what source files these strings are in?

Ok, found it.

gilgongo commented 3 years ago

De-tagging from release as it's not a quick fix.

ignotus666 commented 3 years ago

I know how to fix it but not sure when I'd be able to send it in. It's not complicated.

Edit: turns out it's not as simple as I thought and I don't know how to fix it. That'll teach me to be a clever clogs.

ann0see commented 2 years ago

De-Tagged since PR was closed and we're waiting on a refactoring of the settings.

pljones commented 2 years ago

De-Tagged since PR was closed and we're waiting on a refactoring of the settings.

Which won't happen in 3.9.1, so moved to 3.10.0.

pljones commented 1 year ago

Dropping milestone and moving to backlog. It'll definitely not happen for 3.10.0 unless someone comes up with a straightforward fix that's compatible with the existing command line parser.