Android: Duplicate permissions in Manifest

hoffie commented 2 years ago

Describe the bug

When installing the Android adb logcat shows warnings regarding duplicate permissions in the Manifest.

To Reproduce

Install APK (or probably any other version)

Expected behavior

No warnings in the log

Screenshots

02-19 11:51:35.040 31937 31937 W PackageParser: Ignoring duplicate uses-permissions/uses-permissions-sdk-m: android.permission.INTERNET in package: com.github.jamulussoftware.jamulus at: Binary XML file line #19
02-19 11:51:35.041 31937 31937 W PackageParser: Ignoring duplicate uses-permissions/uses-permissions-sdk-m: android.permission.WRITE_EXTERNAL_STORAGE in package: com.github.jamulussoftware.jamulus at: Binary XML file line #21

Operating system

Android

Version of Jamulus

3.8.2rc1

pljones commented 2 years ago

Anyone know how to get this resolved? Is there a related fix raised? It sounds pretty simple if someone knows how to change the installer to check first.

ann0see commented 2 years ago

Tagging for 3.9.1

hoffie commented 2 years ago

There have been manifest changes via #2640. It should be re-checked, if this issue has been fixed as a side effect.

pljones commented 2 years ago

Waiting for an update here.

pljones commented 2 years ago

Moving to 3.10.0. If there's no confirmation that it's still a problem there, it'll get closed.

ann0see commented 2 years ago

I doubt it's fixed. @sthenos can you please have a look at Android? Do we know anyone else who knows more about Android?

pljones commented 1 year ago

Moving out of 3.10.0 and back to Triage until someone can pick it up.

pljones commented 1 year ago

Doesn't look like we have much Android interest. Dropping milestone.

pljones commented 1 year ago

We can try to look into this at least for 3.11.0. If not, it can probably be closed if it's just a warning.

jamulussoftware / jamulus

Android: Duplicate permissions in Manifest #2403