search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

linux/sound.h should not depend on src/server.h #2628

Closed ann0see closed 2 years ago

ann0see commented 2 years ago

One thing I noticed when I was doing my various changes... linux/sound.h depends on src/server.h. It shouldn't - not sure if you want to go fixing this here, though. (It means moving the high resolution timer from src/server. to src/util. - was a simple cut-n-paste.)

Originally posted by @pljones in https://github.com/jamulussoftware/jamulus/pull/2575#issuecomment-1100919070

pgScorpio commented 2 years ago

I think we better create a new file i.e. timers.h. util.h is already becomming a receptacle (or trash can) with a lot of code that is not really "utility". Better to keep specific code in specific files.

Is there already someone working on this one?

ann0see commented 2 years ago

Probably @pljones

https://github.com/pljones/jamulus/compare/patch/move-high-precision-timer...pljones:patch/rethink-int-ext-serverlist-entry?expand=1

pljones commented 2 years ago

I think we better create a new file i.e. timers.h.

I'm not sure it's "big" enough to warrant that -- too many files with tiny amounts of code in is a nightmare to manage.

util.h is already becomming a receptacle (or trash can) with a lot of code that is not really "utility".

Agreed on that point. Something needs doing.

Is there already someone working on this one?

Yep.