jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
1.01k stars 224 forks source link

Make about dialog show up as fullscreen on iOS #3344

Closed ann0see closed 1 month ago

ann0see commented 3 months ago

Short description of changes Fixes an UI overflow bug for the about dialog on iOS.

Related to: #3343 Now - with some potential device rotations the about dialog can be exited on Qt6: About dialog iOS

CHANGELOG: CONDENSE WITH #3343

Context: Fixes an issue?

Related to: #3343

Does this change need documentation? What needs to be documented and how?

No Status of this Pull Request

Ready

What is missing until this pull request can be merged?

Nothing

Checklist

ann0see commented 1 month ago

Not sure if you can test this. But please review.

softins commented 1 month ago

@ann0see could you explain what the problem behaviour without this fix is? I have just run an old Jamulus I have on my iPad (3.8.2beta1dev-75e4ad0c), and the About and Connect dialogs already show up as full screen with the OK or Connect buttons visible. Running iOS 16.7.10.

I can't remember how I got the above version of Jamulus onto my iPad. The icon is just a rounded white square with the word Jamulus in the middle.

softins commented 1 month ago

Or is the problem just on an iPhone instead? (I don't have one)

ann0see commented 1 month ago

The icon is just a rounded white square with the word Jamulus in the middle.

This is a version from the AppStore and not official in any way.

This issue only shows up on Qt6 based iOS builds.

ann0see commented 1 month ago

@pljones coumd you please also have a look at this?

pljones commented 1 month ago

Looks okay, too. AboutDialogFullScreen (Landscape only when I'm in Jamulus, moto g(9) power, Android 11)