jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
1.01k stars 224 forks source link

Add changable bundle id and docs for macOS signing #3348

Closed ann0see closed 2 months ago

ann0see commented 3 months ago

Short description of changes

Adds variable for a changable Bundle ID for notarization for macOS. One can add the bundle id here: https://github.com/jamulussoftware/jamulus/settings/variables/actions/new

Also adds some more (basic) documentation which needs improvement as soon as signing works, and some clean up.

CHANGELOG: Autobuild: Use variable for Bundle ID on macOS. This allows to change the bundle ID for macOS notarization on GitHub

Context: Fixes an issue?

No. Related to: https://github.com/jamulussoftware/jamulus/issues/3255#issuecomment-2295387824

Does this change need documentation? What needs to be documented and how?

Maybe the signing - once it works.

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged? Review (language wise)

Checklist

ann0see commented 3 months ago

Potentially this needs splitting into multiple commits.

pljones commented 3 months ago

Will this be in for 3.11.0 release? If so we should put it on the tracking board as in progress for the release. As it affects the release process, I feel we should try to target a release...

ann0see commented 3 months ago

Yes. Agree

ann0see commented 2 months ago

Maybe this will be replaced by another PR soon. I'm refactoring the build script for macOS now.

ann0see commented 2 months ago

Ok. Superseded by: #3352