jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
998 stars 222 forks source link

Remove executable bit from connectdlg #3370

Closed ann0see closed 1 week ago

ann0see commented 2 weeks ago

Short description of changes

Removes executable bit from connectdlg.cpp. Not sure why it was executable in the first place. This was introduced in https://github.com/jamulussoftware/jamulus/commit/d5d1ab0625af0302b404ab620c65c37798b1aef7

CHANGELOG: SKIP Context: Fixes an issue?

No. This was fixed by https://github.com/jamulussoftware/jamulus/pull/3364/commits/38fb4144de9ae5a1c52c664ced5a399e943db499#r1749287067 by me

Does this change need documentation? What needs to be documented and how?

No

Status of this Pull Request

Ready for review

What is missing until this pull request can be merged?

Nothing

Checklist

pljones commented 1 week ago

What happened to the style check here? Rebase and try again?

ann0see commented 1 week ago

I don't think that'll fix it.

pljones commented 1 week ago

OK, looking better.