search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
1k stars 224 forks source link

Build process error and warning for 3.11.0rc1 #3373

Open pljones opened 1 month ago

pljones commented 1 month ago

Describe the bug

When editing the 3.11.0rc1 release, I noticed the following error: image

Probably something in the deployment scripts.

There's also a warning relating to macOs in the output: image but may not be related.

To Reproduce

Cut a release candidate.

Expected behavior

No errors

Version of Jamulus

3.11.0rc1 release build.

ann0see commented 1 month ago

I don't think they are related. I believe there's something wrong in two places.

  1. Deployment upload
  2. macOS caching
ann0see commented 1 month ago

For 1, the cleanest way would be to call gh release upload in the respective scripts instead of the hacky cross platform method we use currently:

https://github.com/jamulussoftware/jamulus/blob/97388abfb6fca1f3fa156c9d22e7350cd59a3dfe/.github/workflows/autobuild.yml#L434-L436

The issue is Windows: https://github.com/cli/cli/issues/5099

Otherwise, we could just upload every file from the deploy directory with a wildcard.

For 2, further investigation is needed.

ann0see commented 1 month ago

I think for now we'll just split the release upload into two artifacts again.

https://github.com/ann0see/jamulus/releases/tag/r0_3_10_0

ann0see commented 1 month ago

Concerning 2, it seems to be comparable to https://github.com/actions/setup-node/issues/362

Maybe we need to use a non standard location to put Qt to, or just delete the cache.

pljones commented 1 month ago

OK, as it doesn't appear to have a discernable negative effect, I'm bumping the problem to after the release.