search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
1k stars 223 forks source link

PyLint install fails during Code Style check #3408

Open pljones opened 1 week ago

pljones commented 1 week ago

Describe the bug

Running pip install --user "pylint < 3.0" fails with an error, causing the overall build to fail with a code style error.

To Reproduce

Raise a PR or run a the "Verify Python coding style" work flow (without --break-system-packages)

Expected behavior

pylint should be install and the check should run successfully (assuming not breakage in python code style).

Additional context

Raised on Discord (note, all old builds now gone):

[ 16:19 ] pljones: Anyone know why the python check fails? https://github.com/jamulussoftware/jamulus/actions/runs/11306641904/job/31447466526?pr=3394 [ 16:20 ] dtinth: recently-updated gh actions image breaks pip. just add --break-system-packages to the command should fix it. example https://github.com/dtinth/jamulus-php/commit/be02a7c6b78ab6fa736ca5a0c3d9041d5436e5a4 [ 16:24 ] pljones: So patch main with that, then revert? [ 17:13 ] pljones: Just patch for now. Is "pylint < 3.0" available on ubuntu-latest? My 24.04 LTS has only 3.0.3 available for apt; maybe it could use pipx rather than --break-system-packages?

$ apt list pylint
Listing... Done
pylint/noble,noble 3.0.3-2 all
ann0see commented 4 hours ago

@pljones the fixes on main don't seem to fix the issue.