search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
989 stars 222 forks source link

Add support for IPv6 #46

Closed tduboys closed 3 years ago

tduboys commented 4 years ago

Hi, I'm trying to use Jamulus with my own dedicated server in both ipv4+ipv6 stack.

When I try to connect to the DNS with A and AAAA record, nothing happens. I dont see any packets sent from my client, and on my server (with wireshark). When I use the IPv4 directly, all is working. When I use the IPv6 directly, I see my client sending a lot of packets to 127.0.0.1:22124

Is there something wrong on my setup or on the client part regarding IPv6 ?

I'm using Jamulus 3.4.4 on Archlinux Thanks

gene96817 commented 3 years ago

Sadly, this is already possible, either by directly using the protocol, playing with strange local ip addresses or using command line flags.

So I'd say that this should not be the deciding criterion.

I agree the current system is not secure. What would push us to need security in this area? The straightforward solution would be to require every server to have a valid cert (not a self-signed cert) and use IPSEC (part of IPv6). I expect a lot of allergic reactions to this kind of solution. Anything else might add a bit more security (through complexity) but adding complexity is not security

mstolle629 commented 3 years ago

Hello, my version works now on Windows, Linux and Mac.
I have one possible regression, but this could be fixed easily: I work with ipv6 mapped ipv4 addresses. If there is no ipv6 stack at all in the OS, jamulus might not work. This could be fixed easily in the init code of the socket. Shall i fix this before pull request - or shall i send a pull request first? In a second step, the protocol should be extended for central server support of ivp6 addresses.

ann0see commented 3 years ago

Hi all, please have a look at https://github.com/jamulussoftware/jamulus/pull/1938 for working direct connection IPv6 support.

ann0see commented 3 years ago

Closing since https://github.com/jamulussoftware/jamulus/discussions/1950 is the next step to get towards full IPv6 support. Basic IPv6 support will be possible with v3.8.1 (and the -6 CLI flag)