search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

Add version string to flatpak build #965

Closed ann0see closed 3 years ago

ann0see commented 3 years ago

Currently the automatic flatpak build doesn't have a version number. @nefarius2001 do you want to fix it (probably just a small change)?

nefarius2001 commented 3 years ago

can do. should it be in the filename only, or also in the package description? I have no experience with flatpack so far, anyone who can give a hint what is important?

ann0see commented 3 years ago

I think file name only is ok. No idea how to do it in the flatpak file.

nefarius2001 commented 3 years ago

Suggestion:

The "app-id": "io.jamulus.Jamulus" in the manifest will stay unchanged I will rename the input parameter "bundle" for the github-action https://github.com/bilelmoussaoui/flatpak-github-actions as follows: "io.jamulus.Jamulus.flatpak" => "jamulus_${{jamulus_buildversionstring}}.flatpak"

ann0see commented 3 years ago

Just found out: There's a PR pending for flathub. Maybe this isn't needed anymore then.

https://github.com/jamulussoftware/jamulus/issues/803#issuecomment-774684410

nefarius2001 commented 3 years ago

does that mean flatpak can be disabled as a total? (if/when PR is accepted there)

ann0see commented 3 years ago

Probably yes. So I will close this issue and re-open it if flathub doesn't accept it.