jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

submodule checkout broken #984

Closed nefarius2001 closed 3 years ago

nefarius2001 commented 3 years ago

Describe the bug PR #934 breaks git checkout

reproduce git clone --recurse-submodules https://github.com/jamulussoftware/jamulus >>> FAIL git clone --recurse-submodules git@github.com:jamulussoftware/jamulus.git >>> FAIL

This is mandatory for github autobuilds (#978), but slipped in Auto-Checks because those do not yet use submodules.

@pljones What command is your PR aiming for? Can it be improved to fit your needs and have the above still work?

hoffie commented 3 years ago

Thanks for the report. I can confirm. I think the github.com/ part doesn't belong there. Gonna open a PR in a minute.

ann0see commented 3 years ago

Thanks @hoffie!

pljones commented 3 years ago

I shouldn't try to rush things so much...