search

jamulussoftware / jamulus

Jamulus enables musicians to perform real-time jam sessions over the internet.
https://jamulus.io
Other
997 stars 222 forks source link

Do not automatically open Jamulus after install with new installer #995

Closed ann0see closed 3 years ago

ann0see commented 3 years ago

Is your feature request related to a problem? Please describe. Once a new user without admin privileges installs Jamulus and the installer opens the app, it might run as administrator and therefore not as the person who is currently logged in. This means that the user might think that settings are not saved once he re-opens Jamulus with his user privileges. Describe the solution you'd like I suggest not to automatically open Jamulus after the installer ran, although it might be a bit more inconvinient for the user. It would not cause confusion.

Describe alternatives you've considered

--

Additional context

--

pljones commented 3 years ago

It should be possible to run without Administrator privs.

ann0see commented 3 years ago

Of course it is. But if you tick the run app checkbox since the installer ran as admin, Jamulus will also run as admin.

pljones commented 3 years ago

It's possible to drop Administrator privs when spawning another application, as far as I remember.

ann0see commented 3 years ago

That would be great! Do you know how to do do it with NSIS?

pljones commented 3 years ago

No - but I know Reaper does it and it uses NSIS, AFAIK.

ann0see commented 3 years ago

Ok. See my PR. I found a workaround.