search

jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.
https://jamulus.io
GNU Lesser General Public License v2.1
16 stars 79 forks source link

Translations update from Hosted Weblate #855

Closed weblate closed 1 year ago

weblate commented 1 year ago

Translations update from Hosted Weblate for Jamulus/Startpage.

It also includes the following components:

Current translation status:

Weblate translation status

hoffie commented 1 year ago

@ignotus666, @ann0see, @pljones: Hrm, this PR contains three commits and I don't see authorship information in any of them. :(

Is there still a problem with the Github integration / squash configuration?

ann0see commented 1 year ago

It's configured that way.

The reason behind that was that personal email gets leaked. As the the main repo has the checkbox enabled, probably enable it here too?

trebmuh commented 1 year ago

Remarks/questions:

ignotus666 commented 1 year ago

@trebmuh

it's a bit strange that a bunch of (French translation) files get there "last translator" field updated while there is no update in the file in a bunch of other software I'm translating (or have been involved in), when a translator update a file, his name is defined as the "last translator" and the name of his predecessor is moved on a line below. I like that way since it shows the "team" and it doesn't feel that the last translator is the only one. Could we envisage to have the same system here?

I'm not sure why weblate decides to update just the header section and count that as an update by "x" translator. I can only presume it's because @jujudusud opened those files in weblate even if he didn't actually edit them.

As for your second point, I've been poking around the settings and I can't see anything related. I'll try to explore it further when I get a chance.

ignotus666 commented 1 year ago

Another mystery is why weblate suddenly takes it upon itself to wrap text when it has a plugin enabled explicitly to prevent this. It's done it to the Korean version of "Running a Server" but none others...

hoffie commented 1 year ago

in a bunch of other software I'm translating (or have been involved in), when a translator update a file, his name is defined as the "last translator" and the name of his predecessor is moved on a line below. I like that way since it shows the "team" and it doesn't feel that the last translator is the only one. Could we envisage to have the same system here?

Could that be this addon? https://docs.weblate.org/en/latest/admin/addons.html#contributors-in-comment

ignotus666 commented 1 year ago

Could that be this addon? https://docs.weblate.org/en/latest/admin/addons.html#contributors-in-comment

Looks like it, yes! @ann0see do you see any problem with adding this? I ask because it includes contributors' emails.

trebmuh commented 1 year ago

Looks great, thanks for the nice finding @hoffie

ann0see commented 1 year ago

@ignotus666 as long as my E-Mail is not on the release branch and others are ok with it, feel free to manage/install it on Weblate.

ignotus666 commented 1 year ago

Done.

ann0see commented 1 year ago

Another mystery is why weblate suddenly takes it upon itself to wrap text when it has a plugin enabled explicitly to prevent this. It's done it to the Korean version of "Running a Server" but none others...

Maybe not every component has it enabled?

ignotus666 commented 1 year ago

I checked when I installed this last add-on and yes, it's enabled in all of them. Besides, it would have done it to all languages in that component. I just updated the Spanish translation of "Running a Server" and there's no wrapping. It's weird.

henkdegroot commented 1 year ago

This PR fixes #850

ann0see commented 1 year ago

Attention: I will merge this in about one hour.

ann0see commented 1 year ago

Merged.