jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.
https://jamulus.io
GNU Lesser General Public License v2.1
16 stars 79 forks source link

Update PR template to include note about Weblate #901

Closed ignotus666 closed 1 year ago

ignotus666 commented 1 year ago

Short description of changes Update this PR message template to include warning about merging Weblate PRs first if the change affects translations.

Context: Fixes an issue? Related issues Should help prevent conflicts caused by skipping this step.

Status of this Pull Request

What is missing until this pull request can be merged?

Does this need translation?

NO

Checklist

ignotus666 commented 1 year ago

Maybe we could create a label too, something like "Merge weblate translations first" or something like that? It could probably be automated - if the workflow detects changes to translatable docs (it already does that), add the label too.

ignotus666 commented 1 year ago

if(weblate has open PR and this PR changes English documentation) { fail check "Weblate merge" }

Mark the "Weblate merge" check as compulsory on GitHub.

If I understand that right, wouldn't it require re-running the workflow after the hypothetical Weblate PR has been merged?

ann0see commented 1 year ago

Probably yes. Although there might be ways around that (Weblate PR merge check triggers other check)