jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.
https://jamulus.io
GNU Lesser General Public License v2.1
16 stars 79 forks source link

Translations update from Hosted Weblate #908

Closed weblate closed 1 year ago

weblate commented 1 year ago

Translations update from Hosted Weblate for Jamulus/Startpage.

It also includes the following components:

Current translation status:

Weblate translation status

henkdegroot commented 1 year ago

@ann0see , I noticed there is a lot to translate/update on weblate. Will try to fix by 27 march on weblate.

henkdegroot commented 1 year ago

@ann0see, a separate note, it seems some links are broken in the text due to the updates made to the page. Will these be checked using a script?

ann0see commented 1 year ago

I think so - we run a linkchecker before releasing the site. But it's good to fix them now - if you come across some.

henkdegroot commented 1 year ago

@ann0see, they will need to be fixed in the source....it might cause some conflicts on weblate/PR. In the Running a Server page, there are server types (1, 2 and 3). In weblate, the 1, 2 and 3 have been removed and the wording is changed. I.e. 1. Registered is now Registered mode. I notice a couple of links pointing to these. I can update the translation but that is also really hard using weblate to understand all links.

ann0see commented 1 year ago

No. Then don't fix them now. We should get this PR in first.

henkdegroot commented 1 year ago

@ann0see, I have completed all updates using Weblate (hope I will not have to use that too often as it is really slow). Hope the updates will appear soon in the PR.

Regarding the link, seems there is just 1 link which has an issue. Should be easy to spot with the link checker script.

henkdegroot commented 1 year ago

Checking the website locally and notice the following error: po4a-error

Don't think this is caused by the translation, but not sure how best to report the error.

Maybe it is related, I noticed the following text does not show translated: website-translation

And I have checked, it is translated in the copyright.po file.

ignotus666 commented 1 year ago

The po4a message is nothing to worry about, it's just pointing out a potential error. We'll have to look into why the translation of that text doesn't get picked up.

henkdegroot commented 1 year ago

@ignotus666, the ASIO text in the footer is also not showing translated text. Do you want me to create a new issue for this?

henkdegroot commented 1 year ago

Please advise if you want me to report/create separate issues or report issues I find on this PR.

The below is related to the macOS installation page (but there are more pages that have this issue).

English view: image

Translated nl view: image

As you can spot, the list is not handled correct in the translation.

ignotus666 commented 1 year ago

@henkdegroot yes please, maybe open an issue for each type of problem. In the one you posted images of, it's because of the formatting of the EN text. Adding a new line after "To open Jamulus" fixes it. There isn't even a need to update the translations after correcting it - they display ok (just tested locally). Thanks for pointing this stuff out!

henkdegroot commented 1 year ago

@ignotus666, I created a few issues :) and used [Next-release] in the header so they can easily be identified.

henkdegroot commented 1 year ago

We'll have to look into why the translation of that text doesn't get picked up.

Create issue #914 for this, which also contains a solution.

ignotus666 commented 1 year ago

Thanks a lot!

henkdegroot commented 1 year ago

In the one you posted images of, it's because of the formatting of the EN text. Adding a new line after "To open Jamulus" fixes it. There isn't even a need to update the translations after correcting it - they display ok (just tested locally).

Not sure how you have tested or which file you updated. When I add the new line, the list is fixed but it is not showing the translation. And updating the po files, will require updating the translation as well. Think these changes need to be done after merging this PR.

ignotus666 commented 1 year ago

Not sure how you have tested or which file you updated. When I add the new line, the list is fixed but it is not showing the translation. And updating the po files, will require updating the translation as well. Think these changes need to be done after merging this PR.

I added the new line in /wiki/en/Installation-for-Macintosh.md, ran po4a-update-templates.sh and then po4a-create-all-targets.sh. Building the website locally it all looks ok and the translations are there - except in places where it's missing because I'm using next-release without the latest translation updates. The source text should never be edited in .po files.

But yes, before correcting the EN files, we should wait for this PR to go in.

ann0see commented 1 year ago

@ignotus666 please look over your translation again - then freel free to merge this.