search

jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.
https://jamulus.io
GNU Lesser General Public License v2.1
16 stars 79 forks source link

[Next-release] User & Server Manual contains a section which is not translated. #912

Closed henkdegroot closed 1 year ago

henkdegroot commented 1 year ago

URL Testing this locally using the next-release branch. User Manual: http://127.0.0.1:4000/nl/wiki/Software-Manual Server Manual: http://127.0.0.1:4000/nl/wiki/Running-a-Server

Describe the bug The User Manual contains a section which is not translatable.

image

Similar section found in the Server Manual:

image

ignotus666 commented 1 year ago

Weird. The GH action for #909 ran correctly but the .po files didn't get updated with this change.

ignotus666 commented 1 year ago

I re-ran the job, it updated the .po files properly, but now it borked Weblate... AARRGHH. We really must merge Weblate PRs before committing ANY changes to EN files.

ignotus666 commented 1 year ago

@ann0see I reverted the .po file update that messes up Weblate. I think the way to proceed would be to merge the Weblate PR as it is, re-run the job for #909, and then Weblate would be ready with the update from there.

ann0see commented 1 year ago

? I reverted the po file thing yesterday?

ann0see commented 1 year ago

Ah. I understand now. I reverted the automated commit to re enable Weblate translations. This disabled the translation of this section. Today you recreated the po files and we got conflicts again. So I'd suggest to wait translating this section. First ensure the Weblate stuff is correct and can be merged.

ignotus666 commented 1 year ago

Fixed by #921.