search

jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.
https://jamulus.io
GNU Lesser General Public License v2.1
15 stars 81 forks source link

[Next-release] Translated copyright text not showing #914

Closed henkdegroot closed 1 year ago

henkdegroot commented 1 year ago

URL http://127.0.0.1:4000/nl/

Describe the bug With NL selected as the site language, the text in the navigation and footer section are not showing in Dutch but always show in English.

Navigation section: image

Footer section: image

henkdegroot commented 1 year ago

I found the cause of this issue and this can be fixed by updating the _po4a-tools/po4a-create-all-targets.sh script.

image

The highlighted section needs to be extended to include the reference to the copyright file.

image

Not sure if the copyright file also needs be excluded from the threshold calculation.

ignotus666 commented 1 year ago

@henkdegroot feel free to make a PR with the fix (here and elsewhere) - this week I'm going to be very pressed for time...

I'm not sure about excluding it from the threshold -I'm inclined to think it doesn't need to be- but maybe a quick test to confirm it would be best.

henkdegroot commented 1 year ago

Can this issue be linked to #917 ?

ignotus666 commented 1 year ago

Yes, this can be closed now.