919 Update "--directoryserver" to "--directoryaddress"

jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.

https://jamulus.io

GNU Lesser General Public License v2.1

15 stars 81 forks source link

919 Update "--directoryserver" to "--directoryaddress" #928

Closed pljones closed 1 year ago

pljones commented 1 year ago

Short description of changes

Bring documentation inline with latest code.

Context: Fixes an issue? Related issues

https://github.com/jamulussoftware/jamulus/pull/3017 updated Jamulus to use --directoryaddress for the Directory address command line argument.

Status of this Pull Request

Text files updated.

What is missing until this pull request can be merged?

Reviews.

Does this need translation?

Probably not - this is an untranslatable string.

Checklist

[x] I've verified that this Pull Request follows the general code principles
[x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
[x] I'm sure that this Pull Request goes to the correct branch

ann0see commented 1 year ago

Just as warning: this could result in conflicts with a Weblate PR.

ignotus666 commented 1 year ago

@pljones it looks like you edited the .po files - you shouldn't do that. You just have to edit the relevant EN files in wiki/en, let po4a propagate the changes to the .po files when the PR is merged, and then edit them - on Weblate or the "old way" (locally).

I don't understand why Server-Troubleshooting has been edited for some languages and not for others. Is there a reason?

And finally, in wiki/en, only Directories.md and Running-a-Server.md have been edited, while Include-Server-Commands.md and Server-Troubleshooting.md should also be edited, shouldn't they? It doesn't matter though - by just sticking to editing the files in wiki/en, these oversights won't happen.

@ann0see the files affected here don't overlap with any in the Weblate PR so there shouldn't be problems, but I think any Weblate PRs should be merged first as a rule of thumb, just in case.

pljones commented 1 year ago

@pljones it looks like you edited the .po files - you shouldn't do that. You just have to edit the relevant EN files in wiki/en, let po4a propagate the changes to the .po files when the PR is merged, and then edit them - on Weblate or the "old way" (locally).

Argh, that's dumb programmer error again. I grepped for all src files containing the string and changed all instances. Should have limited to src/*.*!