919 Update "--directoryserver" to "--directoryaddress"

jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.

https://jamulus.io

GNU Lesser General Public License v2.1

16 stars 79 forks source link

919 Update "--directoryserver" to "--directoryaddress" #929

Closed pljones closed 1 year ago

pljones commented 1 year ago

Short description of changes

Bring documentation inline with latest code.

Context: Fixes an issue? Related issues

https://github.com/jamulussoftware/jamulus/pull/3017 updated Jamulus to use --directoryaddress for the Directory address command line argument.

Status of this Pull Request

Text files updated.

What is missing until this pull request can be merged?

Reviews.

Does this need translation?

Probably not - this is an untranslatable string.

Checklist

[x] I've verified that this Pull Request follows the general code principles
[x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
[x] I'm sure that this Pull Request goes to the correct branch

pljones commented 1 year ago

Did you check that there isn't any other location? I quickly checked if there is a Include-Server-Commands file or similar, but there isn't.

(I might run the grep later on)

In jamulussoftware/jamuluswebsite it should all be covered. My original grep / sed had not limited to src - I'd also included the po files:

 sed -i -e 's/--directoryserver/--directoryaddress/g' $(grep -lr -- --directoryserver)

The grep should have been grep -lr -- --directoryserver | grep -v '/po/\|^\.git'.

ignotus666 commented 1 year ago

I quickly checked if there is a Include-Server-Commands file or similar, but there isn't.

It should be removed from the po file directories - I wasn't aware that this file didn't exist in wiki/en any more. It's not on Weblate so no harm done.