jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.
https://jamulus.io
GNU Lesser General Public License v2.1
16 stars 79 forks source link

Document macOS ini file sandbox requirements #936

Closed ann0see closed 11 months ago

ann0see commented 11 months ago

Short description of changes Adds a short description for macOS users where the ini files should be saved to due to the sandbox.

Context: Fixes an issue? Related issues

Related to: https://github.com/jamulussoftware/jamulus/issues/2131

Status of this Pull Request

Ready for review. Path was verified.

What is missing until this pull request can be merged?

Ready for review

Does this need translation? YES

Checklist

ann0see commented 11 months ago

@gilgongo could you please have a look at this?

ann0see commented 11 months ago

Quoting you here:

"On macOS, the path to the file must be relative to /Users//Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/ (turn on "Show Library folder" in "Show view options" in the Finder to see this). So a file name with no path is recommended. Note that the legacy version of Jamulus does not have this restriction."

So we might want to add that to the documentation. But it still makes the text quite long.

gilgongo commented 11 months ago

Or if we assume that people on macOS who are interested in .ini files will know how to navigate to things, we could shorten it a bit to:

"On macOS, the path to the file must be relative to /Users/<username>/Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/. So a file name with no path is recommended. Note that the legacy version of Jamulus can read the file from any location."

ann0see commented 11 months ago

I think that's more confusing. Why give the path if you don't even need to give it? Therefore I'd prefer to say that it gets saved there.

gilgongo commented 11 months ago

I think that's more confusing. Why give the path if you don't even need to give it? Therefore I'd prefer to say that it gets saved there.

How about:

"On macOS, simply provide a file name only, since all config files can only be read from /Users/<username>/Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/. Note that the legacy version of Jamulus for macOS can read from any location."

Or if we think people don't need the "no path" thing explaining:

"On macOS all config files must be saved in /Users/<username>/Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/. Note that the legacy version of Jamulus for macOS can read from any location."

ann0see commented 11 months ago

I'd prefer the first one

"On macOS, simply provide a file name only, since all config files can only be read from ~/Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/. Note that the legacy version of Jamulus for macOS can read from any location."

we can use ~/ instead of the username stuff

ann0see commented 11 months ago

I'll drop mentioning the legacy should be considered as deprecated.

gilgongo commented 11 months ago

we can use ~/ instead of the username stuff

Although we did wonder if macOS users would know what $HOME meant, so let's hope they know what ~/ means as that won't let them get to the file path in the Finder if they wanted to do that.

ann0see commented 11 months ago

I believe finder would support that. It's the normal user directory.

gilgongo commented 11 months ago

I believe finder would support that. It's the normal user directory.

As I noted earlier though, you have to explicity show Library or you can't see it in the Finder.

ann0see commented 11 months ago

True. Probably worth documenting that. Could you please add a suggestion?

gilgongo commented 11 months ago

I think we'd have to have the full path in there for that though, because if you didn't know what ~/ meant you would not know to go to home in the Finder and then turn on the Library, because that option is only available from the Finder's home location.

"On macOS, simply provide a file name only, since all config files can only be read from /Users/<username>/Library/Containers/io.jamulus.Jamulus/Data/.config/Jamulus/ (turn on "Show Library folder" in "Show view options" to see this in the Finder). Note that the legacy version of Jamulus for macOS can read from any location."

ann0see commented 11 months ago
  1. I'll not mention the legacy version as it is deprecated.
  2. See the changes for a slightly adapted version including the server.
  3. There's no need to mention the .config/Jamulus folder, as that's ONLY for the default config file. If someone adds a new one, it won't be saved there.
gilgongo commented 11 months ago

Oh OK (what do you mean in your point 2?), so more like:

"On macOS, simply provide a file name only, since all config files must be in /Users/<username>/Library/Containers/io.jamulus.Jamulus/Data/ (turn on "Show Library folder" in "Show view options" to see this in the Finder)."

ann0see commented 11 months ago

For 2. See the current state of this PR (= the change in my commit)

ann0see commented 11 months ago

@gilgongo Please merge if this is finished. I think the state is ok.