Update Installation-for-Linux.md adding PipeWire usage.

jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.

https://jamulus.io

GNU Lesser General Public License v2.1

16 stars 79 forks source link

Update Installation-for-Linux.md adding PipeWire usage. #980

Closed jujudusud closed 4 months ago

jujudusud commented 6 months ago

Adding informations for PipeWire

Short description of changes Adding informations to use Jamulus with a PipeWire's distribution instead of JACK.

Context: Fixes an issue? Related issues fixes #979

Status of this Pull Request The text needs to be discussed by everyone.

What is missing until this pull request can be merged? Mergeable.

Does this need translation? YES, it needs to be translated.

Checklist

[x] I've verified that this Pull Request follows the general code principles.
[x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
[x] I'm sure that this Pull Request goes to the correct branch.
[x] Any outstanding Weblate updates/PRs must be pushed/merged before merging this.

ignotus666 commented 6 months ago

Reminder: any outstanding Weblate updates/PRs must be pushed/merged before merging this.

Cheers @jujudusud!

jujudusud commented 5 months ago

Is it possible to merge this one?

ann0see commented 5 months ago

After weblate is merged.

jujudusud commented 4 months ago

Squash merge an tell the translators that those changes are made.

jujudusud commented 4 months ago

Please keep in mind that this PR is an update to add PipeWire usage and not a complete rewriting of the whole page.

pljones commented 4 months ago

Looks good now to me -- the comment for qjackctl feels much better where it is.

gilgongo commented 4 months ago

Please keep in mind that this PR is an update to add PipeWire usage and not a complete rewriting of the whole page.

Hehe - most website PRs seem to attract various other updates along the way though.

jujudusud commented 4 months ago

Please keep in mind that this PR is an update to add PipeWire usage and not a complete rewriting of the whole page.

Hehe - most website PRs seem to attract various other updates along the way though.

;-) We should open another PR though. One problem = one PR.

pljones commented 4 months ago

One problem = one PR.

No, one issue = one PR. The PR should do a good job of resolving the issue. If that includes additional related refactoring, that's not just acceptable, it's required.

mcfnord commented 4 months ago

I've spent 20 years updating documentation for a living. Our system has a lot of friction. Translation is a major reason why. Ok, fine. This view about PRs being limited in scope is proper for code, but less proper for information targeted at humans. What we need is a low-friction means to make small improvements everywhere, easily. What we have is this. If you agree that a suggested change would improve our publication, approve it and move on. I guess the downside is that someone who wants to cover just one thing doesn't get their wish. All I ask is for suggestion approval when it's clear the proposed change is an improvement.

jujudusud commented 4 months ago

All I ask is for suggestion approval when it's clear the proposed change is an improvement.

No problem with that. I just wanted to say that I've opened an issue to make up for the lack of PipeWire support. Then I proposed a PR to fix the issue. After that, we started to modify the whole documentation file. I'm willing to make improvements, but I'm not in a position to make all the changes that might be necessary.