Update deprecated actions

jamulussoftware / jamuluswebsite

This is the GitHub Pages repository for the Jamulus main website. For the jamulus application source code, please visit jamulussoftware/jamulus.

https://jamulus.io

GNU Lesser General Public License v2.1

16 stars 79 forks source link

Update deprecated actions #984

Closed ignotus666 closed 2 months ago

ignotus666 commented 2 months ago

Short description of changes Actions haven't been updated for some time and some versions are close to being unsupported.

Context: Fixes an issue? Related issues

Status of this Pull Request 2nd attempt - should be ready; tested and working on my fork.

What is missing until this pull request can be merged?

Does this need translation?

No.

Checklist

[x] I've verified that this Pull Request follows the general code principles
[x] I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
[x] I'm sure that this Pull Request goes to the correct branch

ignotus666 commented 2 months ago

When testing the website artifact created by the gh action, the gemfile isn't there, leading to an error. If I manually paste it into the folder, it works fine. I don't really know much about this stuff... @ann0see any ideas?

ignotus666 commented 2 months ago

Testing on a clone of my fork the website works fine, so something's happening in the gh action creating the artifact.

ann0see commented 2 months ago

Thank you very much. That's odd. Does jekyll update create it?

ann0see commented 2 months ago

I mean: the artifact is the compiled website, I think. So it doesn't have the gemfile. But the repo should.

ignotus666 commented 2 months ago

@ann0see Huh... I just downloaded it again and tried it with the command jekyll serve (instead of bundle exec jekyll serve) and it worked. So it was just a case of me getting my commands mixed up...