jamz903 / pe

0 stars 0 forks source link

Add should check for duplicate field values #3

Open jamz903 opened 11 months ago

jamz903 commented 11 months ago

UG specifies that it does not allow contacts with duplicate full names to be added, but does not talk about other fields.

A contact application should have validation to check for duplicate emails, or duplicate numbers and warn the user, but the application does not check.

nus-se-bot commented 11 months ago

Team's Response

We recognise that this is a legitimate feature flaw to warn the user on duplicate emails/phone numbers.

However, the team puts forward that this feature flaw is less critical than the existing added features, and hence response.NotInScope.

The reasoning is as follows :

  1. Duplicate emails / phone numbers are a legitimate and reasonably common use case, like in the case of multiple contacts sharing a work email account (like HR email communications going through one address)
  2. The value proposition from this is relatively small, as the inconvenience incurred by the user on incorrect but duplicate vs just incorrect phone number / email is minimal.

I.e. for every instance where a user enters a duplicate, incorrect phone number / email, it is about as likely that they enter an incorrect phone number / email that isn't a duplicate, and the steps to remedy this issue in the current iteration are exactly the same (edit ......)

E.g. it does not really make a difference to the user if they entered "duplicate@duplicate.com" instead of "wrongEmail@wrongemail.com", as both are wrong and will need correcting.

Also, we downgrade the severity of the bug to severity.Low, as it would only cause minor inconvenience if they enter the duplicated emails.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]