jamz903 / pe

0 stars 0 forks source link

Phone number does not accept prefix for country code #5

Open jamz903 opened 10 months ago

jamz903 commented 10 months ago

This should be accepted as it is typical for an address book to allow the user to input the country code so that it is easier to dial others. The current feature blocks the usage of + and spaces, but one of the above formats should be accepted. i.e., +6512345678 or 65 12345678

nus-se-script commented 10 months ago

Team's Response

The severity has been changed to severity.Low as this only causes a minor inconvenience and does not affect the app functionality.

Our target audience are also undergraduates, so our target users are more likely to only have local numbers, and thus having international numbers would be a less common occurence.

Severity: Screenshot 2023-11-20 at 12.51.40 AM.png

Our target user (from our DG):

Screenshot 2023-11-20 at 12.55.01 AM.png

From the textbook:

Screenshot 2023-11-20 at 12.32.41 AM.png

Adding additional parsing for country codes would require more input checking.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: > Connexion is a desktop application for you to manage your networking connections.

our target users are more likely to only have local numbers

I disagree with this, as it is quite common to meet international students or make connections with visiting professionals during networking events, since NUS is quite a diverse community. I believe this would cause an occasional inconvenience to users, and thus I put Medium Severity.

image.png