search

jan-dolejsi / vscode-pddl

Planning Domain Description Language (PDDL) grammar, syntax highlighting, code snippets, parser and planner integration for Visual Studio Code.
MIT License
84 stars 22 forks source link

Extension causes high cpu load #20

Closed senpl closed 5 years ago

senpl commented 5 years ago

I got that notification so i post it. I hope it will be enough to reproduce it. jan-dolejsi.pddl-unresponsive.cpuprofile.txt jan-dolejsi.pddl-unresponsive.cpuprofile.zip jan-dolejsi.pddl-unresponsive.cpuprofile.zip

:warning: Make sure to attach this file from your home-directory: /home/m/jan-dolejsi.pddl-unresponsive.cpuprofile.txt :warning: jan-dolejsi.pddl-unresponsive.cpuprofile.txt

Find more details here: https://github.com/Microsoft/vscode/wiki/Explain:-extension-causes-high-cpu-load

jan-dolejsi commented 5 years ago

Thanks. Investigating!

jan-dolejsi commented 5 years ago

@senpl, unfortunately the dumps do not include the name of the extension or anything I would recognize. Did you observe a performance problem?

senpl commented 5 years ago

In general yes. Was it because this extension I am not sure. I think my main issue is that extension work even when I do not want it to (no file present, not activated or anything). That way it contribute to general cpu load. So I guess not starting until user wants would be good improvement. Anyway I uninstall it and not wish to investigate it any longer.

jan-dolejsi commented 5 years ago

Ok, I understand and sorry to hear that. In any case, this is how the extension gets activated:

"activationEvents": [ "onLanguage:pddl", "onLanguage:plan", "onLanguage:happenings", "workspaceContains:*/.pddl", "workspaceContains:*/ptest.json", "onCommand:pddl.configureParser", "onCommand:pddl.configurePlanner", "onCommand:pddl.showOverview", "onView:pddl.planning.domains" ],

If you had any .pddl files in the open workspace, it would load. Was that the case? I could wait till one of those files gets open, by removing this one:

"workspaceContains:*/.pddl"

On Mon, Feb 18, 2019, 14:20 Michał Urbanek <notifications@github.com wrote:

In general yes. Was it because this extension I am not sure. I think my main issue is that extension work even when I do not want it to (no file present, not activated or anything). That way it contribute to general cpu load. So I guess not starting until user wants would be good improvement. Anyway I uninstall it and not wish to investigate it any longer.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jan-dolejsi/vscode-pddl/issues/20#issuecomment-464729058, or mute the thread https://github.com/notifications/unsubscribe-auth/AXScHdIwnU7boajaUO9VK-IJB14RDmQ7ks5vOqisgaJpZM4anKBE .

senpl commented 5 years ago

To me it looks like pddl was autogenerated, because their were always added as git new files, anyway anything that will not eat users cpu when not active is good to have.

jan-dolejsi commented 5 years ago

Let's close this as the activation on *.pddl files anywhere in the workspace was disabled.