search

jan-gerling / FLOCKA

1 stars 1 forks source link

Refactorings #35

Open jan-gerling opened 5 years ago

jan-gerling commented 5 years ago

Please put all ideas, concerns for refactorings here, so we won't forget them.

jan-gerling commented 5 years ago

Rename IdManager to IdResolver, because the term Manager is confusing with the separation from IdGenerator

jan-gerling commented 5 years ago

Service Configs: move exposed port from sharding to service scope

jan-gerling commented 5 years ago

Service Base: make it abstract class such that it takes config path and stores exposed ports (service's) and probably hostname (e.g. akka.remote.netty.tcp.hostname)

Putting it in the sharding base is confusing, because it does not belong there.