Exit Command does not shut down the program if pie or bar windows are open

[jan-kai1]

When executing the Exit Command with extra windows of pie or bar open, the program does not shut down.

While it is acknowledged in the User Guide that the extra windows will not be closed, the program itself does not stop running as well.

With a pie window open:

State of Terminal Prior to exiting:

State of Terminal upon exiting (either through exit or x in the window)

As can be seen, it is impossible for the user to re run the program or use the terminal at all in this state.

Terminal only returns to normal state upon closing the extra window(s).

This is an inconvenience that can commonly occur as users may forget to close the extra windows they have open. As users can remedy the issue by closing the extra windows, this would not make the bug have a high severity, marking it as medium

[soc-se-bot]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Exit command does not close the program when executed

The UG states that the exit command should close the program.

But the program is still running in the background in the terminal.

This is a problem, since users may forget to close the windows, and the program will continue to run in the background.

If the user does not realise this, multiple instances of the program may build up in the background, which can lead to slow downs and confusion between the diagrams windows. Especially if the old diagram contains outdated data.

---

_{[original: nus-cs2103-AY2425S1/pe-interim#2191] [original labels: severity.Medium type.FunctionalityBug]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for the report.

The intended workflow for the cli-savvy private tutor is to press Esc after executing bar or pie. It is true that if they choose to alt-tab or click on the main window to type the exit command, the pie and bar charts will remain open.

As it is rare for a private tutor to go out of their way to close the program without closing the bar/pie window, and it does not impact their workflow or corrupt their data in any way, we think this should be low severity.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---

## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [x] I disagree **Reason for disagreement:** The team notes in the User Guide that the command will not close all windows, and seems to indicate that having the user manually close other windows before using `exit` is the intended way to use the command. Therefore I think in this case it is a feature flaw as this decision to not shut down the app completely seems intentional by the team and the flaw lies with the designed intended workflow rather than the functionality itself.

---

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I disagree with the team's view that this is a rare occurrence and should therefore be of low severity. Contrary to what the team suggests, users do not have to "go out of their way" to forget to close extra windows. Leaving extra windows open is an extremely common occurrence, especially for data view windows such the ones created by the app (`bar`, `pie` and `info`). Users are far more likely to accidentally leave them open rather than conscientiously and meticulously close each and every one after they are done. Here is a common scenario where a window could be left open: - open extra `bar` or `pie` windows to look at data - Leave the data open for further reference or just forget to close it as it is not particular disruptive to their device's performance - Tab back to the original app page - After a while, close the app when they are done The user would then realize that they are now unable to run anything using their terminal and have to manually close all the extra windows. This is not an uncommon situation and does not fit the low severity suggested by the team. A user is far more likely to leave a window open accidentally than they are to meticulously close each one as is suggested by the team. Having the exit command fully terminate a program is a common user expectation and the failure of the command to do so here is very likely to confuse users and delay them, causing inconvenience in a common situation and leading to a severity of medium.

---