search

jan-vandenberg / cruddiy

No-code Bootstrap PHP CRUD generator
http://cruddiy.com
GNU Affero General Public License v3.0
253 stars 80 forks source link

Easy fix to search parameter not being passed along in URL when paging #45

Closed dooleysworne closed 2 years ago

dooleysworne commented 2 years ago

Line 54 in templates.php

Change

$parameters = $GET ? $_SERVER['QUERY_STRING'] : "" ;

to

$parameters = $_GET ? $_SERVER['QUERY_STRING'] : "" ;

Solves the problem of the search parameter not being passed along in the URL when paging.

jan-vandenberg commented 2 years ago

What version of Cruddiy are you using (or which git commit)? Because this line is not in the code.

See here: https://github.com/jan-vandenberg/cruddiy/blob/master/core/templates.php#L54

dooleysworne commented 2 years ago

??? In https://github.com/jan-vandenberg/cruddiy/blob/master/core/templates.php#L54, $GET needs to be changed to $_GET

jan-vandenberg commented 2 years ago

Wow, I did not catch this because my development branch wasn't synced with master (which was ahead).

Fixed now in https://github.com/jan-vandenberg/cruddiy/commit/5222763d11e79c0173119c119ec12d2b79cd6ecb

Thanks for pointing this out!