search

jan-warchol / selenized

Solarized redesigned: fine-tuned color palette for programmers with focus on readability.
MIT License
754 stars 56 forks source link

Emacs support #28

Open skalyan91 opened 7 years ago

skalyan91 commented 7 years ago

Please add support for Emacs.

Also, it would be nice to have a GTK theme along the lines of Numix Solarized, but this is of course not a high priority.

jan-warchol commented 7 years ago

Hi @skalyan91 !

I will be delighted to add support for Emacs :-) However, I don't have any experience using it, so I'll need your help. Do you have a simple example Emacs config that I could base my work on? I've looked at solarized for Emacs, but it's quite complex and I'd rather start with something simpler.

jan-warchol commented 7 years ago

PS GTK theme would be great indeed, but I want to tackle terminals and text editors/IDEs first.

skalyan91 commented 7 years ago

Sorry for the delay in replying.

A simple way of generating an Emacs color theme would be to use an online generator such as http://emacs-theme-creator.appspot.com.

Once you've created the basic theme, then you could gradually expand it by referring to existing themes such as https://github.com/chaoflow/.emacs.d/blob/master/tango-theme.el. (I agree that solarized for Emacs has too many bells and whistles to start with.)

Of course, another approach would be simply to take solarized.el, and do a find-and-replace of all the colors (and replace all occurrences of "solarized" with "selenized"). I think that should work, too.

jan-warchol commented 7 years ago

Hi!

sorry, somehow I only saw your message today. Thanks for the links, they are very helpful - I'll put up a first version of the emacs config as soon as I have some spare time (which most probably means this weekend).

skalyan91 commented 7 years ago

Thanks! Looking forward to it.

jan-warchol commented 7 years ago

Hi @skalyan91,

sorry for delay! I've generated scheme files using theme-creator and pushed an initial version to devel branch (in emacs/ dir). Can you try it?

jan-warchol commented 7 years ago

PS I see now that theme-creator adds some colors on its own to the resulting theme file (i.e. colors that were not input in the web form). I'll have to figure out what they are doing.

skalyan91 commented 7 years ago

Sorry for the delay. Yes, the theme looks pretty good! See below:

screen shot 2017-03-17 at 5 51 19 pm

Just a couple of points:

  1. The modeline needs a bit of work (particularly under Spacemacs, which I’m using): the border should be removed, and the gray text should be made brighter. Also, the buffer numbers at lower left are hard to read.
  2. The fringe should have the same colour regardless of whether there are line-continuation characters.

Later, if you like, I’ll look for the variables that you’d need to change to get these colours working properly.

jan-warchol commented 7 years ago

I'm glad you like it!

Yes, your comments make sense. Unfortunately I'll be offline for the whole weekend and then I'll have a busy week, so probably I won't be able to dig into it until next weekend.

But if you manage to find which variables to override it would be most welcome :-) feel free to send me a PR, I should manage to take care of it within 1-2 days.

All the best!

17 mar 2017 07:57 "Siva Kalyan" notifications@github.com napisał(a):

Sorry for the delay. Yes, the theme looks pretty good! See below:

[image: screen shot 2017-03-17 at 5 51 19 pm] https://cloud.githubusercontent.com/assets/2990272/24032107/769f3b26-0b3a-11e7-9331-7fb972bd6834.png

Just a couple of points:

  1. The modeline needs a bit of work (particularly under Spacemacs, which I’m using): the border should be removed, and the gray text should be made brighter. Also, the buffer numbers at lower left are hard to read.
  2. The fringe should have the same colour regardless of whether there are line-continuation characters.

Later, if you like, I’ll look for the variables that you’d need to change to get these colours working properly.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jan-warchol/selenized/issues/28#issuecomment-287281443, or mute the thread https://github.com/notifications/unsubscribe-auth/ABThvPDjSR_1mmfsLfZQJINeYaws2lRqks5rmi7mgaJpZM4MChLR .