feat: update github release model - Githubissues

jan-zabloudil / release-manager

Platform-agnostic tool that streamlines daily operations in release management, planning and deployments 🚀

BSD 3-Clause "New" or "Revised" License

2 stars 0 forks source link

feat: update github release model #109

Closed jan-zabloudil closed 3 months ago

jan-zabloudil commented 3 months ago

Updates the GithubRelease model in the service
Updates the release creation process in the repository to also save GitHub release data

To keep PR smaller, other changes will be added once this PR is merged.

bolshakoff commented 3 months ago

Oh no, from my view it looked nice, and like in one thread one by one.. 🤦‍♀️

bolshakoff commented 3 months ago

But actually OK, it's in chronological order from top to bottom. 👌

bolshakoff commented 3 months ago

And it's duplicated. 😶 🤦‍♀️

bolshakoff commented 3 months ago

Blocks #105 for a while.

bolshakoff commented 3 months ago

That might be a relatively big change though; and a deviation from wireframes etc.

Also, the two usage scenarios - might be worth checking with Marek. 😬

Or I can simply let it be processed more during sleep. 😄

jan-zabloudil commented 3 months ago

After discussions outside of GitHub, we concluded that we will maintain integration with GitHub. However, we will simplify the service and repository GitHub release model and remove the denormalization state created by keeping GitHub repository slugs in the GitHub release repo model.

jan-zabloudil commented 3 months ago

In the end, I am closing this one. We will choose a different approach.