working again - Githubissues

janLo / hdr-script-container

Docker container containing http://linuxdarkroom.tassy.net/hdr-creation-script/installation-on-ubuntu/

3 stars 2 forks source link

working again #2

Closed sirber closed 4 years ago

sirber commented 7 years ago

Hi,

I got it working again, plus it now fetches pfstools and opencv. opencv is compiled whitout ffmpeg, opencl and cuda.

Regards,

Stéphane

janLo commented 7 years ago

Thank you! As stretch will be released next year I prefer to not roll back to jessie because of some obscure jpeg lib. But I'll have a look into it as soon as I find time.

Can you cleanup your PR a bit?

remove commented out code
keep the changes as small as possible
there is no point in running apt-get-clean in a separate RUN call, as the packages are already committed to the FS-Layer before

sirber commented 7 years ago

Hi, I'm not sure on how I can do that. Do I close this one and create a new one?

janLo commented 7 years ago

Try to just push your changes to the branch you created the PR from. Normally this should update the PR.

sirber commented 4 years ago

3 years later... closed.