janaboy74 / wfeditormk66

Watchface editor for MK66
GNU General Public License v3.0
6 stars 1 forks source link

Binary data of Hour, Minute, Second hands (Item type 1~3) #5

Open yoohose opened 1 month ago

yoohose commented 1 month ago

I found some issue.

In your project( watchface.h ), each Item struct of watch face file has dummy memebers. (ex "unsigned short dummy1", "unsigned short dummy2", "unsigned int dummy3" ) But when Item type is 1~3 (which means Hour, Minute, Second hands. ), "unsigned int dummy3" has meaning data. if "dummy3" has data like 0x786718 (big endian) , that means     ・Item width:0x18 (24 pixel)     ・Item height:0x78 (120 pixel)     ・Item's center( spin axis? ):0x67 (103 pixel ).

I tested my watch( QX7, D1 ) but did not test another watches.

janaboy74 commented 1 month ago

Hi!

I have now invited you to make improvements. I have now not much time to do this.

Greetings, János

yoohose @.***> ezt írta (időpont: 2024. máj. 30., Cs 10:52):

I found some issue.

In your project( watchface.h ), each Item struct of watch face file has dummy memebers. (ex "unsigned short dummy1", "unsigned short dummy2", "unsigned int dummy3" ) But when Item type is 1~3 (which means Hour, Minute, Second hands. ), "unsigned int dummy3" has meaning data. if "dummy3" has data like 0x786718 (big endian) , that means ・Item width:0x18 (24 pixel) ・Item height:0x78 (120 pixel) ・Item's center( spin axis? ):0x67 (103 pixel ).

I tested my watch( QX7, D1 ) but did not test another watches.

— Reply to this email directly, view it on GitHub https://github.com/janaboy74/wfeditormk66/issues/5, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANDIDWAHSFBWTMOT5SGH6VDZE3SENAVCNFSM6AAAAABIQPPQGOVHI2DSMVQWIX3LMV43ASLTON2WKOZSGMZDKMJRGYYDAMY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

yoohose commented 1 month ago

@janaboy74 Hi, I'm request merge to main branch for this issue. The reqeust link is here: #7