search

janaindrajit / primePy

This module cal quickly find prime factors with multiplicity of a given number. This module also has several other prime factor functions.
MIT License
3 stars 4 forks source link

Hi I’m a beginner and found a typo #2

Open toastchosetoo opened 3 years ago

toastchosetoo commented 3 years ago

Hi recently I started learning python.

And I found a typo in primePy module site ( https://pypi.org/project/primePy/ )

I think, sentence: [primes.facors(n) returns all the prime factors of n with multiplicity.] has typo in paragraph of Available methods.

facors -> factors right? if it isn’t just pass it

I am just new beginner and don’t know exactly what to do if I found uncertain typo in the site

so I left it

I wrote this post on python community at first And someone suggested me to leave it here. here is the link https://discuss.python.org/t/hi-im-a-beginner-and-found-a-typo/5926

hanefi commented 3 years ago

Hi @toastchosetoo

I also realized that typo and opened a PR to fix it in a PR #3

I did not check the currently open PRs, and found out that there was a similar PR #1 that also fixed that typo.

Both of the PRs contain more changes than that, but you can check them out.

In the future, you can go ahead and and submit a Pull Request yourself. Here is how you can do that:

  1. Go to the main page for this repo.
  2. Find the pencil icon fir editing the readme. It is on the top right corner of the body.
  3. Do necessary changes
  4. Fill out the forms below and provide a meaningful description on what you changed and why.
  5. Submit
  6. Open a PR