search

janaipakos / ghibliapi

A simple API for Studio Ghibli resources. Unofficial/fan-made
https://ghibliapi.herokuapp.com
MIT License
310 stars 109 forks source link

Remove Swagger base path #32

Closed jackelder closed 3 years ago

jackelder commented 3 years ago

When importing the swagger spec into Insomnia or Postman, the basePath adds an extra / to the URLs, since each of the paths already includes a leading /.

For example, the films URL is imported as https://ghibliapi.herokuapp.com//films rather than https://ghibliapi.herokuapp.com/films

I removed the base path so that the correct paths are imported. This doesn't impact the URLs displayed by redoc (it looks like redoc wasn't including the basePath).

jackelder commented 3 years ago

@phil-lindstedt noted that the id field had type integer in several spots in the spec when it should be string so I changed those. I also made some fixes to the response object structures.

janaipakos commented 3 years ago

@phil-lindstedt noted that the id field had type integer in several spots in the spec when it should be string so I changed those. I also made some fixes to the response object structures.

@jackelder @phil-lindstedt thank you!