search

janastu / swtr

The canonical swt maker + swt swagger application
5 stars 2 forks source link

Which are the various formats of images and webpages supported? #27

Closed navyasn closed 9 years ago

navyasn commented 9 years ago

While trying with .jpg files and html pages, Annotation is working. However, some new formats like .gif are not working. Should this be supported?

ecthiender commented 9 years ago

The following image works; which is a gif: http://servelots.com/images/logo_blue.gif

Which image did not work for you? Can you share the link?

Also, the following image formats are supported: jpg, jpeg, png, gif, bmp, svg (basically the formats natively supported by any standard browser)

If any image does not have an extension (.something), we try to fetch the image and see if it is among the supported images and then load it.

It'll be helpful if you can share the image link, and then we can all try to reproduce the error and see what is going wrong.

ecthiender commented 9 years ago

Hi Navya,

Did you check this after that? Does it work with other gifs? Or does it fail?

Can you check with the same file again(on which it was failing)?

Let me know. We should follow up this issue.

navyasn commented 9 years ago

Hi Anon,

I tried with the gif files today and they are working fine. I only had this issue while using Windows OS.

Regards, Navya

On Thu, Jan 29, 2015 at 7:56 PM, Anon Ray notifications@github.com wrote:

Hi Navya,

Did you check this after that? Does it work with other gifs? Or does it fail?

Can you check with the same file again(on which it was failing)?

Let me know. We should follow up this issue.

— Reply to this email directly or view it on GitHub https://github.com/janastu/swtr/issues/27#issuecomment-72032733.

ecthiender commented 9 years ago

Two questions:

  1. Did you try with the same gif file, with which you faced the issue originally?
  2. Can we test on a Windows machine again to be sure if this is an issue on Windows. (Technically, it should not be! All these are web apps!)
navyasn commented 9 years ago

Yes, I tried with the same image again. Let me check if I can get a windows machine to test again.

On Fri, Jan 30, 2015 at 11:08 AM, Anon Ray notifications@github.com wrote:

Two questions:

  1. Did you try with the same gif file, with which you faced the issue originally?
  2. Can we test on a Windows machine again to be sure if this is an issue on Windows. (Technically, it should not be! All these are web apps!)

— Reply to this email directly or view it on GitHub https://github.com/janastu/swtr/issues/27#issuecomment-72156756.

ecthiender commented 9 years ago

Thanks! Hopefully we can close this issue after that! :)

pradyumnat commented 9 years ago

Tried sweeting .gif images on windows8.1. works on mozilla, chrome and ie.

On Fri, Jan 30, 2015 at 11:21 AM, Anon Ray notifications@github.com wrote:

Thanks! Hopefully we can close this issue after that! :)

— Reply to this email directly or view it on GitHub https://github.com/janastu/swtr/issues/27#issuecomment-72157495.

ecthiender commented 9 years ago

So looks like we don't have this issue anymore. Closing this.