search

janastu / swtr

The canonical swt maker + swt swagger application
5 stars 2 forks source link

Fix base url #44

Closed romanchyla closed 9 years ago

romanchyla commented 9 years ago

Hi, please find here some updates

I've written tests for it, but i don't get it run properly because of the api (sweet store api) not being available (probably as easy as changing configuration)

ecthiender commented 9 years ago

Wow! Roman, thanks a bunch! The commits look damn good. Thanks for helping us out. I'm going to merge this pull request. Hope everything works fine, and nothing breaks!

BTW, how did you come to know about this application? Have you used this application?

ecthiender commented 9 years ago

Also, how can we run the tests? I can help with configuring swtstore endpoints etc. Maybe we can devise a way of running the tests?

romanchyla commented 9 years ago

hi Anon, the /annotate2 was just a test - I thought it is easier to write a simple string manipulation (just add base tag), but then realized it was too clunky - so I removed it (but kept for reference)

tests can be run by:

py.test swtr

you may need to do pip install -r dev-requirements.txt first

i can contribute .travis.yml configuration - and activate also coverage reports later

I'm not using the app myself, but I met Dinesh and told him I'll try to help where I can (though i'm really pressed time-wise, so I'm basically scraping few hours here and there)

arvindkhadri commented 9 years ago

@romanchyla great code, much appreciation.

ecthiender commented 9 years ago

Fix issues. Persona branch is now working.