janbar / noson-app

The essential to control music from your SONOS devices on Linux platforms
GNU General Public License v3.0
335 stars 28 forks source link

Add "Play next" option to song context menu #186

Open albertschulz opened 2 years ago

albertschulz commented 2 years ago

Hey there, My use-case is to create a queue of 100 songs for 3 hours of playback during dance parties. Once I added all songs, I usually reorder the songs, often while music is playing. So far, I just discovered the drag-and-drop option to reorder. But its very painful if the song I want to play very next to the current song playing, is at the very end of the queue. image

A "Play next" which puts it right after the current song in the queue would be a huge improvement for you. What do you think? Is that easy to implement? Would that be also useful to you? Can you give me a hint where I would need to do the change?

janbar commented 2 years ago

You are in the queue playlist, so there is no way to do that. If you want to play as next you could long tap on the current playing track, then move it up to the track you want to play next.

albertschulz commented 2 years ago

Thanks for the fast reply. I agree that this is not possible until now. Your proposed solution works, but is very painful when the queue gets longer than the screen size.

Please see the GIF below to see my pain, and also the solution I already implemented: Peek 2022-05-06 14-28

You can find my branch here: https://github.com/janbar/noson-app/compare/devel...albertschulz:albert/play-next?expand=1

Could I open a pull request for that?

janbar commented 2 years ago

My code is a mess. I saw you anderstand my langage ;-). We could do that also: reorderTrackInQueue(player.currentIndex, model.trackIndex - 1); Then it should play next and all the ones to follow. A pull request is welcome. I will test it.