janbar / osmin

GPS Navigator On-Road/Off-Road for Android and Linux devices
GNU General Public License v3.0
104 stars 17 forks source link

Not finished download can't resume. #63

Open Popolon opened 1 year ago

Popolon commented 1 year ago

I started to download the France datas (on a Linux mobile Phone), but my phone gone out of battery. As a result, download in incomplete, and it is impossible de resume the download. The arrow blink when I click on it, and that's all.

Tied the same thing on desktop Linux, and I can see the following message (i will try to fix "christian_church" (that should be church + appropriate tags),that is probably a problem in an element naming in OSM itself:

qml: installedMapsModel rows: 1
qml: mapDownloadsModel rows: 0
qml: Map download failed: Directory already exists
Basemap found and loaded from ' "/data/users/popolon/osmin/resources/world" '...
1768,10 Warning: Unknown type 'christian_church'
qml: Application state changed to suspended

maybe an rsync, an http resume, or something like that could help to not having do drop the whole directory (here removing europe-france-20230301-092417/ resolved the issue.

janbar commented 1 year ago

You have done the right thing to clean up the failed download. To fix this, we have to handle this case in the download flow from the backend. I guess the latter doesn't try to delete an unknown or invalid map folder in the tree (folder maps).

janbar commented 1 year ago

For the second, some types (i.e christian_church) aren't defined. So it is just a warning. For this case the existing types are: christian_church_building, christian_chapel_building, jewish_synagogue_building, muslim_mosque_building,

janbar commented 1 year ago

Fixed in release 1.11.1