Smarter avatar filtering

janboddez / indieblocks

Use blocks, and, optionally, "short-form" post types to more easily "IndieWebify" your WordPress site.

https://indieblocks.xyz

GNU General Public License v3.0

22 stars 3 forks source link

Smarter avatar filtering #177

Closed janboddez closed 4 months ago

janboddez commented 5 months ago

Possibly related to #176.

Ideally, I'd rather not serve 3rd-party images from my domain. I'd rather "cache" them locally and serve those. And remove the cache and serve nothing, for instance, if somehow I don't want to serve a certain image at all.

But ... avatars may change over time. So, serving them through some reverse proxy of sorts might be preferred? Then if an image gets replaced, we'd automagically start serving the new image "though our proxy." And if it gets deleted, we could include a fallback option of sorts.

janboddez commented 5 months ago

So we'd have both options alongside eachother:

"Cache" affects only how avatars are saved. When this is enabled, we try to save them locally.
"Proxy" affects only how avatars are linked, on display. When this is enabled, remote avatars go through our "proxy." (We should exclude avatars that are already local. This will also exclude previously "cached" avatars, which is perfect.)

Should probably use the get_avatar_url filter rather than the current get_avatar_html (which should only be used for adding microformats).

janboddez commented 4 months ago

Should probably use the get_avatar_url filter rather than the current get_avatar_html (which should only be used for adding microformats).

Delivered in 7f22334. Also, we never really added microformats (because adding u-photo doesn't make sense [in this case] outside of the comment author's .h-card, and unfortunately, the comments block normally generates the blocks/HTML that way.