search

janboddez / share-on-mastodon

Easily share WordPress posts on Mastodon.
https://jan.boddez.net/wordpress/share-on-mastodon
GNU General Public License v3.0
39 stars 5 forks source link

Add new filter to adjust client/app name #48

Closed florianziegler closed 1 year ago

florianziegler commented 1 year ago

Hey Jan,

thank you for creating this plugin! 🙌

Not sure if this is something you would consider, but I'd love to be able to change the "client name" shown on Mastodon. (Eg. I myself would love to use my own domain name.)

Cheers Florian

janboddez commented 1 year ago

Let me consider. It's the only bit of "promotion" the plugin has, other than regular word of mouth. (Not that I care that much, and I know it can be hidden from the Mastodon settings.) And clicking the name, i.e., "Share on Mastodon," will already bring you to your site, something other plugins don't do. :-)

The other thing is, this setting/name is only used whenever a new "client" is registered, which in our case means immediately after the Mastodon URL is filled out. (It is not sent along with every post or anything.)

So we'd need very clear instructions: "Add the filter before doing anything else!"

Blogger Chris Aldrich has also mentioned how to edit the actual plugin to accomplish the same thing. While this is something I'd normally advise against, as changes are overwritten by updates, in this case it probably doesn't matter all that much; it only has to be "correct" once.

Another solution would be to provide an extra (but optional) input field, "app name," or something, and add this quite important disclaimer in its "description."

florianziegler commented 1 year ago

I totally understand. I was a bit hesitant to even suggest such a change, as you said, the client name is the only visible place, where your plugin is mentioned in the whole process.

I thought, the fact that it is a filter (and not an option) and that it has to be set even before connecting to Mastodon, means that only people specifically looking for it, would actually find/use it. Not sure if this is even interesting for the majority of users…

(For my own use I could use a fork and sync the upstream changes.)

Thanks again for creating this plugin! 🙏

janboddez commented 1 year ago

Closed this by accident (removed the master branch, moved to main as the main branch). But I've also included the change (which would, again, only actually do something when used before first setting the instance URL).

https://github.com/janboddez/share-on-mastodon/blob/2b0fe324526ce33c7ee7b18a9463fd7f2c821472/includes/class-options-handler.php#L374